Closed jed326 closed 2 weeks ago
@andrross @bugmakerrrrrr @sohami could you review this PR as it is related to #11443?
:x: Gradle check result for 8c4fd86a989eb51ff3090541f1fe25417d70a85b: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for ceeb08ab48a27c2da9225141073b31bfbafba6ac: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for 65497a053b9ed432a3620cc865273ddcaf9693e6: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:white_check_mark: Gradle check result for 2de2403420fd5495ccd379a6d3f13256c672bb20: SUCCESS
Attention: Patch coverage is 87.50000%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 72.11%. Comparing base (
034bd2b
) to head (ca32a2f
). Report is 3 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...org/opensearch/index/store/IndexStoreListener.java | 80.95% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
lgtm. Will wait for others to approve as well
:grey_exclamation: Gradle check result for ca32a2f85b36a99d93d757b0b01cee169a084dbf: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.
Description
I have a use case where I have a custom file cache implementation and in order to not have dangling entries in my fc I need to implement
IndexStoreListener
to clean up my file cache when shards move off a node. Today that is not possible asIndexStoreListener
is an@opensearch.internal
interface and not pluggable, which this PR changes.Long term I think the solution is to make the FileCache itself pluggable, but that is much more complicated and anyways would require us to expose this interface as pluggable, so I believe this is a useful intermediary step.
The other thing to note is in
Node.java
I am now creating theCompositeIndexStoreListener
regardless of if itisSearchNode()
or not as it should be up to the specific listener implementations to determine how/when to perform their action.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.