search

opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.85k stars 1.83k forks source link

Detect Breaking Changes check does not fail on new method added to an @PublicApi interface #16585

Closed reta closed 2 weeks ago

reta commented 2 weeks ago

Description

The japicmp plugin was configured to fail only on binary incompatible changes (which new interface method isn't), making checks strick by failing on source incompatible changes.

Related Issues

Closes https://github.com/opensearch-project/OpenSearch/issues/16175

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for bea3746ad52e9404e09d47bca1bb7cd6c7667393: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:white_check_mark: Gradle check result for bea3746ad52e9404e09d47bca1bb7cd6c7667393: SUCCESS

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.01%. Comparing base (034bd2b) to head (bea3746). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16585 +/- ## ============================================ - Coverage 72.04% 72.01% -0.04% + Complexity 65093 65040 -53 ============================================ Files 5314 5314 Lines 303541 303541 Branches 43921 43921 ============================================ - Hits 218683 218580 -103 - Misses 66946 67022 +76 - Partials 17912 17939 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

reta commented 2 weeks ago

@peternied mind please to help me here? thank you! :-)

reta commented 2 weeks ago

Thanks for making this change. Are there any escapees that need to be resolved?

Nope :) At least as of now