opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.84k stars 1.83k forks source link

Fix NPE in CatShardsRequestTests on version bump #16589

Closed dbwiddis closed 2 weeks ago

dbwiddis commented 2 weeks ago

Description

Initializes the indices array with non-null values to prevent NPE.

Related Issues

Resolves #16571

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dbwiddis commented 2 weeks ago

Actually.... this is the wrong fix. The array is intended to be null, the issue is 2.18 branch still has CURRENT causing it to fail on 2.18.1. So I think we just need to backport something there.

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 16eb2dc1b461ef050a2f4b6ea6bf88f5af67fe1b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?