opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.84k stars 1.83k forks source link

[2.18] Fix NPE in CatShardsRequestTests on version bump #16590

Closed dbwiddis closed 2 weeks ago

dbwiddis commented 2 weeks ago

Description

One of the version changes from https://github.com/opensearch-project/OpenSearch/pull/16455/files was missed when it was manually backported in https://github.com/opensearch-project/OpenSearch/pull/16396.

The test in question is intended to check for a previous version that does not read the array of null strings. By leaving it at Version.CURRENT it bumped to 2.18.1 where 2.18.0 was the previous version and incorrectly tried to read that array.

Related Issues

Resolves #16580

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 82d74adf0a128faff140f65810da07248cae0811: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:white_check_mark: Gradle check result for 82d74adf0a128faff140f65810da07248cae0811: SUCCESS

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (2.18@99a9a81). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.18 #16590 +/- ## ======================================= Coverage ? 71.82% Complexity ? 65367 ======================================= Files ? 5312 Lines ? 304995 Branches ? 44440 ======================================= Hits ? 219065 Misses ? 67681 Partials ? 18249 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.