search

opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.85k stars 1.83k forks source link

Extend ./bin/opensearch-plugin install <plugin_name> to include plugins in the default distribution #16597

Closed cwperks closed 2 weeks ago

cwperks commented 2 weeks ago

Description

This PR adds all plugins from the default distribution to the official plugin list in OpenSearch core which enables installation by plugin name.

i.e. This command will work after this change.

./bin/opensearch-plugin install opensearch-security

Related Issues

Related to https://github.com/opensearch-project/OpenSearch/issues/16195

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks commented 2 weeks ago

@reta I decided to open this PR which is related to https://github.com/opensearch-project/OpenSearch/pull/16581. Between this PR and supporting snapshots for native plugins, these 2 PRs will make it so that you can install any native or default plugin using the opensearch-plugin CLI and it would work with either release or snapshot build.

reta commented 2 weeks ago

@reta I decided to open this PR which is related to #16581. Between this PR and supporting snapshots for native plugins, these 2 PRs will make it so that you can install any native or default plugin using the opensearch-plugin CLI and it would work with either release or snapshot build.

@cwperks I am not sure I follow: the official plugins are installed by name (and signed). Any other plugins are installed using file:// location or URL - those are not official plugins, not signed.

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 9653ff285b161389929ae2b3ca99733a67ce6cff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

cwperks commented 2 weeks ago

@reta I decided to open this PR which is related to #16581. Between this PR and supporting snapshots for native plugins, these 2 PRs will make it so that you can install any native or default plugin using the opensearch-plugin CLI and it would work with either release or snapshot build.

@cwperks I am not sure I follow: the official plugins are installed by name (and signed). Any other plugins are installed using file:// location or URL - those are not official plugins, not signed.

Got it. I will close this PR. I am not familiar with the signing process, but I did encounter that when testing out this change.