opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.85k stars 1.83k forks source link

Search dv only IP masks #16628

Closed mkhludnev closed 1 week ago

mkhludnev commented 1 week ago

Description

it fixes an edge case when docvalues-only (index:false) IP field is queried via IP mask (1.2.3.4/22 syntax). Now such query is ignored, this change makes it work.

Related Issues

relate #11508

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 1 week ago

:x: Gradle check result for bf572a8ec26bba6d875e857213b3cabce25efc66: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta commented 1 week ago

@mkhludnev Could you please add entry to CHANGELOG.md for this change? thank you

reta commented 1 week ago

❌ Gradle check result for bf572a8: FAILURE

Please rebase against the latest main

github-actions[bot] commented 1 week ago

:x: Gradle check result for e69ae3c7aea2d2dc0c490d0d18d4a1f839b6d9d4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 1 week ago

:x: Gradle check result for 605a63974a97528968f31464edd42922b455b884: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 1 week ago

:x: Gradle check result for c56ee660bee07804cacc64537618aa02b266ae3e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 1 week ago

:x: Gradle check result for f7eecfc1313d0fb07d06fdb0333b775f4660d67f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 1 week ago

:x: Gradle check result for a859408944681226a1c1c04af559bfe7ff97b902: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 1 week ago

:grey_exclamation: Gradle check result for fa143025da3caf45e93533b9fc02bcd3c60cfc26: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.11%. Comparing base (548a650) to head (ca7569d). Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ava/org/opensearch/index/mapper/IpFieldMapper.java 85.71% 3 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16628 +/- ## ============================================ + Coverage 72.03% 72.11% +0.08% - Complexity 65169 65232 +63 ============================================ Files 5318 5318 Lines 303890 303895 +5 Branches 43968 43972 +4 ============================================ + Hits 218906 219155 +249 + Misses 67051 66773 -278 - Partials 17933 17967 +34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

:white_check_mark: Gradle check result for f5226222f0f2d238817e6551e428dbfb5d58e76f: SUCCESS

reta commented 1 week ago

@msfroh LGTY? thanks!

github-actions[bot] commented 1 week ago

:white_check_mark: Gradle check result for ca7569dc29899c29c2563f605e3e55a1f47715a1: SUCCESS

mkhludnev commented 1 week ago

Thank you so much @reta @msfroh