opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.84k stars 1.83k forks source link

[BUG] System Indices breaking cluster state invariance after upgrade from 2.15 #16643

Open shiv0408 opened 1 week ago

shiv0408 commented 1 week ago

Describe the bug

When we are upgraded our cluster from 2.15 to 2.17, we observed that multiple system indices were having different IndexMetadata on Cluster Manager node and remaining follower nodes. Where system flag is true on cluster manager but on followers it is false with same version. This breaks the invariance guarantee of IndexMetadata being same as cluster manager on all nodes. This has started happening because we have marked various index as system index as part of https://github.com/opensearch-project/security/issues/4439

Related component

Plugins

To Reproduce

  1. Create a multinode 2.15 cluster with plugins such as observability, which create a system index.
  2. Upgrade the cluster to 2.16/2.17
  3. Active Cluster Manager have system flag true for .opensearch-observability index metadata, but all follower show false

Expected behavior

Cluster State Index Metadata should be same for all the nodes.

Additional Details

This is happening in both the causes, with remote_store.publication.enabled: true/false