opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.83k stars 1.83k forks source link

Fix stale cluster state custom file deletion #16670

Closed soosinha closed 2 days ago

soosinha commented 3 days ago

Description

When remote cluster state publication is enabled, cluster state custom objects get uploaded to remote store. The stale file deletion logic deletes stale remote state files. But the cluster state custom files are not getting deleted. This PR fixes the logic for stale cluster state custom file deletion.

Related Issues

NA

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 3 days ago

:x: Gradle check result for 15cc0a91f22fc0c72cc38b5a241e80e950f79456: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

shwetathareja commented 3 days ago

@soosinha lets add the changelog for the bug fix.

github-actions[bot] commented 3 days ago

:x: Gradle check result for 15cc0a91f22fc0c72cc38b5a241e80e950f79456: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

soosinha commented 3 days ago

@shwetathareja Added changelog

github-actions[bot] commented 3 days ago

:grey_exclamation: Gradle check result for 2e1bf62853948635d11a522ddd5fbb2af10404b5: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.09%. Comparing base (3b4fa0e) to head (2e1bf62). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16670 +/- ## ============================================ - Coverage 72.11% 72.09% -0.03% - Complexity 65192 65214 +22 ============================================ Files 5318 5318 Lines 303903 303908 +5 Branches 43970 43974 +4 ============================================ - Hits 219166 219094 -72 - Misses 66786 66888 +102 + Partials 17951 17926 -25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

shwetathareja commented 2 days ago

@soosinha Please raise a new PR for adding /update integ test ensuring delete works for every cluster state entity.