opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.83k stars 1.83k forks source link

Coordinator can return partial results after the timeout when allow_partial_search_results is true #16681

Open kkewwei opened 2 days ago

kkewwei commented 2 days ago

Description

In query phase, the coordinate concurrently search each shard, If any shard is blocked or responds very slowly, the coordination node will be stuck even if the timeout is set.

The pr supports timeout waiting, if the timeout is exceeded, the coordinator considers the shard as failed and gos on the fetch phase.

Related Issues

Resolves https://github.com/opensearch-project/OpenSearch/issues/817#issuecomment-2039383610

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 days ago

:x: Gradle check result for 61d84d1f42cf7d0e3be6f335b45d5423c2363967: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 16 hours ago

:x: Gradle check result for 5172db678172c8929d937f093d48d8d58387eaed: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 14 hours ago

:x: Gradle check result for 5638e3cb447d89defb74bdf84fd0f8fe7a1745bc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 13 hours ago

:x: Gradle check result for 17cef4f5cca377951fa705d0c28595753445d790: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 10 hours ago

:x: Gradle check result for f2cb9f7111a75ccd28d996359f109229582d2f39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?