opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.83k stars 1.83k forks source link

Separating remote download and publication stats #16682

Closed himshikha closed 13 hours ago

himshikha commented 2 days ago

Description

This change is aimed at providing granular metrics for remote download and overall remote incoming publication flow separately.

          "remote_full_download" : {
            "success_count" : 1,
            "failed_count" : 0,
            "total_time_in_millis" : 4,
            "incoming_publication_failed_count" : 0,
            "checksum_validation_failed_count" : 0
          },
          "remote_diff_download" : {
            "success_count" : 2,
            "failed_count" : 0,
            "total_time_in_millis" : 12,
            "incoming_publication_failed_count" : 0,
            "checksum_validation_failed_count" : 0
          }

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 days ago

:x: Gradle check result for 72d5889c30cf117f1536be71c23559d133c5b26a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

soosinha commented 1 day ago

Can you update the description with why this change is needed ?

himshikha commented 1 day ago

I am assuming this won't break ser/de(BWC) with version upgrades

Since we are only adding new field, it shouldn't break BWC

github-actions[bot] commented 1 day ago

:white_check_mark: Gradle check result for 61b8e44d44632424c061099a6263d96ebe966132: SUCCESS