search

opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.53k stars 1.75k forks source link

[BUG] Version increment workflow was not triggered #2013

Open dblock opened 2 years ago

dblock commented 2 years ago

Describe the bug

Version increment workflow introduced in #1816 was not triggered. An identical workflow was triggered in common-utils (https://github.com/opensearch-project/common-utils/actions/workflows/version.yml, https://github.com/opensearch-project/common-utils/actions/runs/1741497956), but wasn't in OpenSearch and job-scheduler either.

Expected behavior

Auto-increment workflows should have run when we tagged 1.2.4.

dblock commented 2 years ago

@downsrob @saratvemulapalli @peterzhuamazon How did you create https://github.com/opensearch-project/job-scheduler/releases/tag/1.2.4.0 vs. https://github.com/opensearch-project/OpenSearch/releases/tag/1.2.4 vs. https://github.com/opensearch-project/common-utils/releases/tag/1.2.4.0?

saratvemulapalli commented 2 years ago

@dblock I manually created the release, the tag did already exist. Just used the github release drafter to release it.

dblock commented 2 years ago

@abhinavGupta16 Did you create tags manually for 1.2.4?

abhinavGupta16 commented 2 years ago

@abhinavGupta16 Did you create tags manually for 1.2.4?

No, we used https://github.com/opensearch-project/opensearch-build/issues/378#issuecomment-999700848 script to create tags for 1.2.4

cc - @peterzhuamazon