search

opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.57k stars 1.76k forks source link

Move job-scheduler plugin from external repo into OpenSearch modules #2534

Open dbbaughe opened 2 years ago

dbbaughe commented 2 years ago

This is to track the work being done to migrate the job scheduler plugin to core repository for 2.0.0 preview.

This originated as https://github.com/opensearch-project/job-scheduler/issues/147.

Have migrated job scheduler to core in fork, and currently in parallel working on upgrading the Index Management plugin to 2.0.0 to use as a way to test the job scheduler migration to confirm it works as expected and fix up any issues with the Gradle configuration of the plugin.

nknize commented 2 years ago

/cc @anasalkouz Marking this as a blocker for public preview. It will need to merge post freeze so I'm happy to backport this enhancement once the 2x branch is cut.

CEHENKLE commented 2 years ago

@nknize Timing aside, can you say more why you think this is the right move (if you do?) to move this into core?

mch2 commented 2 years ago

Not opposed to moving it into core but what is the rationale for having it installed by default as a module instead of an optional plugin?

praveensameneni commented 2 years ago

Please review original issue https://github.com/opensearch-project/job-scheduler/issues/147

mch2 commented 2 years ago

Thanks @praveensameneni, I took a look at that issue but still have the same question.

"However, the plugins in plugins directory are optional and can be un-installed by users."

Why would we not want to give users this option? Would we not get all the upgrade benefits with this as a plugin in the repo?

CEHENKLE commented 2 years ago

I've removed the 2.0/blocker labels because we're past the feature freeze date on 2.0 and the path forward is not clear yet. I'd like to get some more clarity on the proposal and target 3.0

praveensameneni commented 2 years ago

Thanks @praveensameneni, I took a look at that issue but still have the same question.

"However, the plugins in plugins directory are optional and can be un-installed by users."

Why would we not want to give users this option? Would we not get all the upgrade benefits with this as a plugin in the repo?

@mch2 , We can try with moving to plugins directory (making it optional) and later move to modules based on user feedback.

@nknize , Are you open to this approach? Can we plan for 2.1?

dblock commented 2 years ago

I've commented on the proposed PR, https://github.com/opensearch-project/OpenSearch/pull/2608#issuecomment-1102943227, please post your strong opinions there and let's first figure out whether we want to finish & merge or close unmerged that one.