Open Bukhtawar opened 1 year ago
I would like to work on this @Bukhtawar. Will the status code always be a 400
or must it be based on error context e.g 404 in the above example? // CC @andrross
@p1729 Thanks for offering to contribute. Below error codes should do. ConcurrentSnapshotException -> 429 RepositoryException(bucket not found) -> 404
Hi @Bukhtawar, would like to work on this, I was going through the code & maybe I could resolve this. Also, I've found some unused things, if you allow I can improve that. Thanks in advance. cc: @andrross
Hi @Bukhtawar, would like to work on this, I was going through the code & maybe I could resolve this. Also, I've found some unused things, if you allow I can improve that. Thanks in advance. cc: @andrross
Thanks @baba-devv you could pick this up if @p1729 isn't still on it?
Also, I've found some unused things, if you allow I can improve that.
@baba-devv By all means feel free to contribute! Please do submit separate PRs though, as it usually best not to group unrelated things together. If it is a small refactoring or cleanup feel free to submit a PR directly. If it is larger or worth some discussion, then start with an issue describing what you plan to do.
@andrross understood, will try to keep things sorted, thanks.
Hi @Bukhtawar, I would like to work on this issue. I see @baba-devv have resolved partially. I can take the remaining part namely RepositoryException(bucket not found) -> 404. Thanks in advance. cc: @andrross
Hi @Bukhtawar , I'm interested to take up this issue. Can you please assign this to me?
Thanks!
Describe the bug A missing S3 bucket for the snapshot results on a 500 its possible that the bucket has been deleted after association.
Then a concurrent snapshot exception is a 503
https://github.com/opensearch-project/OpenSearch/blob/15161a86491569d94642f3a88174e1389218b303/server/src/main/java/org/opensearch/snapshots/ConcurrentSnapshotExecutionException.java#L45-L62
Expected behavior Errors which are client side misconfiguration or client side operations which aren't supported based on the system's concurrency specification should be a 4xx