opensearch-project / alerting-dashboards-plugin

📟 Manage your monitors, alerts and notifications in OpenSearch Dashboards
https://opensearch.org/docs/latest/monitoring-plugins/alerting/index/
Apache License 2.0
25 stars 88 forks source link

Fit and Finish UX changes Pt 2 #1099

Closed jowg-amazon closed 1 month ago

jowg-amazon commented 2 months ago

Description

Second part of the fit and finish UX changes. This PR makes changes to the datasource alerts card which include:

Data source enabled Screenshot 2024-09-18 at 6 03 45 PM

Data source disabled Screenshot 2024-09-18 at 6 03 01 PM

Issues Resolved

[List any issues this PR will resolve]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jowg-amazon commented 2 months ago

Acknowledge alerts tests passed locally

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  acknowledge_alerts_modal_spec.js         01:46        3        3        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        01:46        3        3        -        -        - 
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.17%. Comparing base (db4af39) to head (f3baa26). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1099 +/- ## ========================================== - Coverage 48.41% 48.17% -0.25% ========================================== Files 237 237 Lines 7052 7110 +58 Branches 1035 1045 +10 ========================================== + Hits 3414 3425 +11 - Misses 3635 3682 +47 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.