Alerting Enhancements: Alerting Comments (Experimental)

toepkerd commented 1 month ago

Issue #, if available:

Description of changes:

CheckList:

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

riysaxen-amzn commented 3 weeks ago

let's add some more tests to verify all the behavior and edge cases.

riysaxen-amzn commented 3 weeks ago

rest lgtm , approving assuming CI will pass. But make sure CI passes before merging

amsiglan commented 3 weeks ago

rest lgtm , approving assuming CI will pass. But make sure CI passes before merging

We will fix the CIs in follow up PR. @toepkerd is working on it

opensearch-trigger-bot[bot] commented 3 weeks ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1561-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d808474cf308943b0424bebe2192c2d8bcfc4b18
# Push it to GitHub
git push --set-upstream origin backport-1561-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-1561-to-2.x.

toepkerd commented 2 weeks ago

CIs have been fixed and merged in this followup PR: #1574

opensearch-project / alerting

Alerting Enhancements: Alerting Comments (Experimental) #1561