opensearch-project / alerting

📟 Get notified when your data meets certain conditions by setting up monitors, alerts, and notifications
https://opensearch.org/docs/latest/monitoring-plugins/alerting/index/
Apache License 2.0
58 stars 99 forks source link

fix integ test failures #1580

Closed riysaxen-amzn closed 2 weeks ago

riysaxen-amzn commented 2 weeks ago

Removed assertion from integ tests causing build failure in jenkins

https://build.ci.opensearch.org/blue/organizations/jenkins/integ-test/detail/integ-test/8329/pipeline/126

If the tests are running on a cluster that has more than just the alerting plugin installed on it, there might be indexes for those plugins created as well, the subsequent assertions are more important, so removed the assertion that checks how many indices exist

Test faIlures in jenkins integ test:

Suite: Test class org.opensearch.alerting.transport.GetRemoteIndexesActionIT

  2> REPRODUCE WITH: ./gradlew ':alerting:integTest' --tests "org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with TRUE include_mappings param" -Dtests.seed=C75572776830D42C -Dtests.security.manager=false -Dtests.locale=ro -Dtests.timezone=Pacific/Enderbury -Druntime.java=21

  2> java.lang.AssertionError: expected:<2> but was:<3>

        at __randomizedtesting.SeedInfo.seed([C75572776830D42C:273B758717CBD74]:0)

        at org.junit.Assert.fail(Assert.java:89)

        at org.junit.Assert.failNotEquals(Assert.java:835)

        at org.junit.Assert.assertEquals(Assert.java:120)

        at org.junit.Assert.assertEquals(Assert.java:146)

        at org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with TRUE include_mappings param(GetRemoteIndexesActionIT.kt:205)

  2> REPRODUCE WITH: ./gradlew ':alerting:integTest' --tests "org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with FALSE include_mappings param" -Dtests.seed=C75572776830D42C -Dtests.security.manager=false -Dtests.locale=ro -Dtests.timezone=Pacific/Enderbury -Druntime.java=21

  2> java.lang.AssertionError: expected:<2> but was:<3>

        at __randomizedtesting.SeedInfo.seed([C75572776830D42C:5240C08E4E2190E6]:0)

        at org.junit.Assert.fail(Assert.java:89)

        at org.junit.Assert.failNotEquals(Assert.java:835)

        at org.junit.Assert.assertEquals(Assert.java:120)

        at org.junit.Assert.assertEquals(Assert.java:146)

        at org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with FALSE include_mappings param(GetRemoteIndexesActionIT.kt:156)

  2> REPRODUCE WITH: ./gradlew ':alerting:integTest' --tests "org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with blank include_mappings param" -Dtests.seed=C75572776830D42C -Dtests.security.manager=false -Dtests.locale=ro -Dtests.timezone=Pacific/Enderbury -Druntime.java=21

  2> java.lang.AssertionError: expected:<2> but was:<3>

        at __randomizedtesting.SeedInfo.seed([C75572776830D42C:21E8F236EC2DDBF]:0)

        at org.junit.Assert.fail(Assert.java:89)

        at org.junit.Assert.failNotEquals(Assert.java:835)

        at org.junit.Assert.assertEquals(Assert.java:120)

        at org.junit.Assert.assertEquals(Assert.java:146)

        at org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with blank include_mappings param(GetRemoteIndexesActionIT.kt:106)

  2> NOTE: leaving temporary files on disk at: /tmp/tmpk47m_ab0/alerting/alerting/build/testrun/integTest/temp/org.opensearch.alerting.transport.GetRemoteIndexesActionIT_C75572776830D42C-001

  2> NOTE: test params are: codec=Asserting(Lucene99): {}, docValues:{}, maxPointsInLeafNode=705, maxMBSortInHeap=5.417424553640299, sim=Asserting(RandomSimilarity(queryNorm=true): {}), locale=ro, timezone=Pacific/Enderbury

CheckList:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.