search

opensearch-project / alerting

📟 Get notified when your data meets certain conditions by setting up monitors, alerts, and notifications
https://opensearch.org/docs/latest/monitoring-plugins/alerting/index/
Apache License 2.0
58 stars 100 forks source link

Support multiple CRON expressions #47

Open adityaj1107 opened 3 years ago

adityaj1107 commented 3 years ago

Issue by Angrboda2 Thursday Aug 22, 2019 at 14:15 GMT Originally opened as https://github.com/opendistro-for-elasticsearch/alerting/issues/100

Complex schedules require more than 1 CRON expression, currently you can only enter 1 CRON expression. This forces you to create complex logic in painless scripting in triggers to create blackout windows which would be much better done using CRON.

adityaj1107 commented 3 years ago

Comment by lucaswin-amzn Thursday Aug 22, 2019 at 16:07 GMT

Hi @Angrboda2, could you please share an example of using multiple cron expressions that can not be solved with a single one? Thanks

adityaj1107 commented 3 years ago

Comment by lucaswin-amzn Monday Aug 26, 2019 at 20:39 GMT

Hi @Angrboda2, was this what you are referring to? https://discuss.opendistrocommunity.dev/t/multiple-cron-expressions-for-blackout-windows/1383

adityaj1107 commented 3 years ago

Comment by Angrboda2 Monday Aug 26, 2019 at 21:33 GMT

Yes exactly.

adityaj1107 commented 3 years ago

Comment by dbbaughe Monday Aug 26, 2019 at 23:52 GMT

We originally had the idea of having a timeframe on the monitor to not run during or at least not notify/create alerts during that timeframe to help with system maintenance windows. Is this the use case you're trying to solve? Or did you have a different use case for wanting blackout windows?

Pinging Eli for input too @elfisher

adityaj1107 commented 3 years ago

Comment by Angrboda2 Tuesday Aug 27, 2019 at 01:04 GMT

Yes I'm essentially trying to black out a maintenance window. Whatever solution gets decided on I would not limit it to a single contiguous time period. Often ad-hoc unexpected maintenance has to be done over multiple days, or ongoing performance issues that take some time to solve, need to be blacked out on irregular schedules.

Requiring scripting in the trigger (which I did successfully) is too much work and it's not obvious on a surface level that there is logic "turning it off".

Maybe I should put in a separate request for this but a master blackout option across all monitors is needed as well.

On Mon, Aug 26, 2019, 7:52 PM Drew Baugher notifications@github.com wrote:

We originally had the idea of having a timeframe on the monitor to not run during or at least not notify/create alerts during that timeframe to help with system maintenance windows. Is this the use case you're trying to solve? Or did you have a different use case for wanting blackout windows?

Pinging Eli for input too @elfisher https://github.com/elfisher

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/opendistro-for-elasticsearch/alerting/issues/100?email_source=notifications&email_token=AMIAKTGS3YLL3H5Z7KPKLYDQGRUD7A5CNFSM4IOVQ5QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5GAWWI#issuecomment-525077337, or mute the thread https://github.com/notifications/unsubscribe-auth/AMIAKTGN22NB6PTVUR3LF6TQGRUD7ANCNFSM4IOVQ5QA .