opensearch-project / anomaly-detection-dashboards-plugin

Manage your detectors and identify atypical data in OpenSearch Dashboards
https://opensearch.org/docs/latest/monitoring-plugins/ad/index/
Apache License 2.0
29 stars 58 forks source link

Remove dataSourceFilter that breaks DataSourceView #837

Closed jackiehanyang closed 1 month ago

jackiehanyang commented 1 month ago

Description

DataSourceView is broken on future playground and TrineoApp, however, no console/network errors shown and can't reproduce it locally.

Pull 2.16 and 2.15 docker image and tested with them. Found that it only breaks under 2.16 docker. The only change between 2.15 and 2.16 is adding this dataSourceFilter for version decoupling work. Suspecting it is because the dataSourceFilter filtered out the version so DataSourceView is giving error says "cannot find data source". Since the scenario where AD uses DataSourceView doesn't require data source filtering, I'm removing the dataSourceFilter check for all DataSourceView usage in AD.

As it cannot be reproduced locally, confirmed the fix with deploying the docker image.

Issues Resolved

[List any issues this PR will resolve]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.