Closed amitgalitz closed 4 weeks ago
cypress test is failing. Can you either fix it or make sure it passes locally?
cypress test is failing. Can you either fix it or make sure it passes locally?
It does pass locally, I'm not sure why its failing here.
Cypress test failed with a different reason now:
plugins/anomaly-detection-dashboard 03:56 4 3 1 - - │ │ s-plugin/vis_augmenter/view_anomaly │ │ _events_spec.js
I think I fixed the timeout error during historical cypress tests in https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/pull/859 and https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1537
Not sure about events_spec.js cypress failure above.
overall lgtm, just I see E2E CI is failing. Please look into that to make sure it won't be a RC build blocker
The backport to 2.x
failed:
The process '/usr/bin/git' failed with exit code 1
To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-854-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b26f8c32489693d36ac5479c99a7d9f1d43ef01d
# Push it to GitHub
git push --set-upstream origin backport/backport-854-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x
Then, create a pull request where the base
branch is 2.x
and the compare
/head
branch is backport/backport-854-to-2.x
.
The backport to 2.17
failed:
The process '/usr/bin/git' failed with exit code 1
To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-854-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b26f8c32489693d36ac5479c99a7d9f1d43ef01d
# Push it to GitHub
git push --set-upstream origin backport/backport-854-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17
Then, create a pull request where the base
branch is 2.17
and the compare
/head
branch is backport/backport-854-to-2.17
.
Description
Issues Resolved
resolves #856 resolves #855
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.