search

opensearch-project / anomaly-detection

Identify atypical data and receive automatic notifications
https://opensearch.org/docs/latest/monitoring-plugins/ad/index/
Apache License 2.0
67 stars 73 forks source link

[Backport 2.x] Not blocking detector creation on unknown feature validation error #1371

Closed amitgalitz closed 3 hours ago

amitgalitz commented 1 day ago

Description

Backporting #1366 to 2.x

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.15%. Comparing base (8bea041) to head (8992d78). Report is 1 commits behind head on 2.x.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensearch-project/anomaly-detection/pull/1371/graphs/tree.svg?width=650&height=150&src=pr&token=ZPONorT0bX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)](https://app.codecov.io/gh/opensearch-project/anomaly-detection/pull/1371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) ```diff @@ Coverage Diff @@ ## 2.x #1371 +/- ## ========================================= Coverage 80.14% 80.15% Complexity 5684 5684 ========================================= Files 533 533 Lines 23435 23439 +4 Branches 2334 2334 ========================================= + Hits 18783 18788 +5 + Misses 3550 3549 -1 Partials 1102 1102 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/anomaly-detection/pull/1371/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [plugin](https://app.codecov.io/gh/opensearch-project/anomaly-detection/pull/1371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `80.15% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/opensearch-project/anomaly-detection/pull/1371?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [.../rest/handler/AbstractTimeSeriesActionHandler.java](https://app.codecov.io/gh/opensearch-project/anomaly-detection/pull/1371?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fopensearch%2Ftimeseries%2Frest%2Fhandler%2FAbstractTimeSeriesActionHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-c3JjL21haW4vamF2YS9vcmcvb3BlbnNlYXJjaC90aW1lc2VyaWVzL3Jlc3QvaGFuZGxlci9BYnN0cmFjdFRpbWVTZXJpZXNBY3Rpb25IYW5kbGVyLmphdmE=) | `95.07% <100.00%> (+0.04%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/opensearch-project/anomaly-detection/pull/1371/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)