search

opensearch-project / ansible-playbook

🤖 A community repository for Ansible Playbook of OpenSearch Project.
https://opensearch.org/
Apache License 2.0
81 stars 97 forks source link

Fixes #111: Build on #113 also address `Unable to find file /etc/selinux/config` error #122

Closed heiderich closed 2 months ago

heiderich commented 1 year ago

Description

This is build on top of #113 of @FactorT.

Issues Resolved

111

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Note that this commit also contains two commits (c5fe1e2ea87b1642585752abea4aa1e3499ce879, cddafd6d00da23225d7f3e68a33e822647cb183c) of @FactorT from #113.

prudhvigodithi commented 1 year ago

Hey @heiderich thanks for the contribution, so once this PR is merged, we dont need https://github.com/opensearch-project/ansible-playbook/pull/113?

heiderich commented 1 year ago

@prudhvigodithi Yes, exactly. The two commits from #113 are included in this PR.

ng-bsy commented 10 months ago

Wow! Almost 8 months now and no one had time to review this? Is this project dead? Is it too much work, reviewing 4 lines of code? If it is, maybe someone else should take over this project? @TheAlgo @prudhvigodithi @gaiksaya @peterzhuamazon @bbarani

TheAlgo commented 10 months ago

@ng-bsy I think there is an open comment by @saravanan30erd which is still open for reply from @heiderich and hence the PR is still open.

ng-bsy commented 10 months ago

@TheAlgo thanks for the quick response. It gives hope, seeing, this project isn't dead :-)

Though I'm asking myself, if it's worth, holding out ~8 months on a bugfix, over the discussion if another piece of code should be removed, that may be having the same or partly the same effect, without really compromising performance. In my opinion, that discussion is another issue (code optimization) and this PR (bugfix) should be merged asap.

prudhvigodithi commented 10 months ago

Thanks @TheAlgo and thanks @ng-bsy for your patience, its true we are holding based on pending conversation, @saravanan30erd are we ok to move forward with this PR based on above comment?

saravanan30erd commented 7 months ago

@prudhvigodithi @peterzhuamazon The concern with this PR is, the way its managed to ignore the errors are limited and not scalable. For example, overall issues are occurring for debian based on this source issue https://github.com/opensearch-project/ansible-playbook/issues/111 but for different versions of python the errors are also different for same debian distribution. As you can see, here https://github.com/opensearch-project/ansible-playbook/issues/111#issue-1575639716 its different error output and here its another one https://github.com/opensearch-project/ansible-playbook/issues/111#issuecomment-1474984451 thats the reason here https://github.com/opensearch-project/ansible-playbook/pull/122/commits/c4b21560b69a57af97261468e36857e7906afe4c#diff-26da4e2fc3ae1d719ad41b3e625de34dd3fbc83814e8a4c6875c55f4fb6f0e91R12 new error output is added. In this case, we might get new error output for new versions and we need to keep on adding those new changes in the search thats why I am pointing out its not scalable. I can see both issues were for debian, so we can ignore completely that distribution for this step so we don't have to cover different error outputs to ignore. Raised the pr for this https://github.com/opensearch-project/ansible-playbook/pull/152 please review it and provide your thoughts.

dblock commented 2 months ago

Thank you for the contribution @heiderich. I think the consensus is not to merge this PR because of the reasons above, @prudhvigodithi should we close it?

peterzhuamazon commented 2 months ago

Close this as it has been handled in #152.

Thanks.