search

opensearch-project / ansible-playbook

🤖 A community repository for Ansible Playbook of OpenSearch Project.
https://opensearch.org/
Apache License 2.0
86 stars 96 forks source link

fixed syntax for multi-node #32

Closed pgalonza closed 2 years ago

pgalonza commented 2 years ago

Signed-off-by: Galonza Peter p.galonza@evaron.ru

Description

This changes fixed mistake in opensearch.yml(opensearch-multi-node.yml) "IllegalStateException[only value lists are allowed in serialized settings]"

Check List [X ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

saravanan30erd commented 2 years ago

@pgalonza Could you please explain when you faced the below issue? what is the value which provides this error?

IllegalStateException[only value lists are allowed in serialized settings]

Current setting with [] is working fine and its explicitly mentioned based on below doc,

https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-node.htmlhttps://www.elastic.co/guide/en/elasticsearch/reference/current/modules-node.html

pgalonza commented 2 years ago

@pgalonza Could you please explain when you faced the below issue? what is the value which provides this error?

IllegalStateException[only value lists are allowed in serialized settings]

Current setting with [] is working fine and its explicitly mentioned based on below doc,

https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-node.htmlhttps://www.elastic.co/guide/en/elasticsearch/reference/current/modules-node.html

@saravanan30erd I faced this problem when checked usual installation on 3 VMs with centos8. When open opensearch configuration file i saw this node.roles: [['ingest', 'data']], because {{ hostvars[inventory_hostname]['roles'] }} return the list with correct syntax, i think it is usual type conversion the list to string.

Tested on:

Screenshots: https://disk.yandex.ru/i/9lj058BYoPe-ZQ https://disk.yandex.ru/i/JBWsGZQcsf5k9A

saravanan30erd commented 2 years ago

@pgalonza ok, when I was tested with python 2.7 and python 3.6 this is not the case and thats why I explicitly mentioned list in config file. Currently we are working on support for Amazon linux & ubuntu PR's. Once thats merged, then we will look into this issue bcoz this requires some more time as it needs to be tested against different versions of python & ansible to reproduce the issue, also we need to check for backward compatibility.

pgalonza commented 2 years ago

I`m tested with inventory in yaml format and attribute was be a list not a string