opensearch-project / ansible-playbook

🤖 A community repository for Ansible Playbook of OpenSearch Project.
https://opensearch.org/
Apache License 2.0
86 stars 96 forks source link

Creating ISM polisies via role #67

Closed ssi444 closed 4 months ago

ssi444 commented 2 years ago

Description

Added the ability to automatically create ISM policies.

Issues Resolved

https://github.com/opensearch-project/ansible-playbook/issues/66

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ssi444 commented 2 years ago

Calling @saravanan30erd @prudhvigodithi for the review. Thanks.

ssi444 commented 2 years ago

@peterzhuamazon @saravanan30erd @prudhvigodithi ping

peterzhuamazon commented 2 years ago

@saravanan30erd Please let me know if you have bandwidth to review this. @ssi444 Sorry we are focusing on two minor releases in the past weeks that is why this is pretty slow. Thanks.

ssi444 commented 2 years ago

@peterzhuamazon @saravanan30erd @prudhvigodithi ping

ssi444 commented 2 years ago

@peterzhuamazon @saravanan30erd @prudhvigodithi ping

prudhvigodithi commented 1 year ago

Hey @ssi444 apologies for the delay, do you think we still need this change to move forward?

prudhvigodithi commented 1 year ago

Hey @ssi444 apologies for the delay, do you think we still need this change to move forward?

ssi444 commented 1 year ago

Hey @ssi444 apologies for the delay, do you think we still need this change to move forward?

This is one of the important tasks for using this role as an IaC. In production, we most often add ISM and index pattern (PR #68)

prudhvigodithi commented 1 year ago

Thanks @ssi444, @peterzhuamazon please add your thoughts on this PR and index pattern (PR https://github.com/opensearch-project/ansible-playbook/pull/68) Thank you

peterzhuamazon commented 1 year ago

Thanks @ssi444, @peterzhuamazon please add your thoughts on this PR and index pattern (PR #68) Thank you

Hi all,

We welcome the contribution but it looks like doesn't cater to wider variety of users as it specifically add settings for a plugin or two.

Need more discussion on whether this is addition to the repo, or is just support for user-specific scenario. Let me know what you guys think @bbarani @gaiksaya @rishabh6788 .

Thanks.

ssi444 commented 1 year ago

If the number of users using this role for regular cluster updates according to the IaC methodology is insignificant, then it may not be worth implementing this PR. We are actively using this in production and I decided to share our best practices with the community. With this role we manage:

There are plans to complete the management of visualizations and dashboards. We don't use them at home, but if the community is interested, then I can make the necessary improvements.

bbarani commented 1 year ago

Anyone looking in to this PR? @prudhvigodithi @peterzhuamazon @TheAlgo

dblock commented 4 months ago

Looks like there was no consensus of what to do with this PR. Closing it as stalled, please reopen if you don't agree!

[Catch All Triage - Attendees 1, 2, 3, 4, 5]