Closed DarshitChanpura closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: No coverage uploaded for pull request base (
main@a0e9476
). Click here to learn what that means.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
should be merged post https://github.com/opensearch-project/security/pull/4061 is merged
Hello reviewers,
This could be potential reason for failing tests with security atleast at the distribution level for 2.13.0. Looks like it would need backport to 2.x and 2.13? Please review and merge.
Thanks!
multi-node test workflow is currently broken on main unrelated to this. Attempting to resolve that first
Haven't been able to resolve the bwc issue quickly. Will go ahead with this to unblock testing of 2.13
The backport to 2.x
failed:
The process '/usr/bin/git' failed with exit code 1
To backport manually, run these commands in your terminal:
# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/asynchronous-search/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/asynchronous-search/backport-2.x
# Create a new branch
git switch --create backport/backport-539-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a39c93466aff946677ef63104e03026358b189a
# Push it to GitHub
git push --set-upstream origin backport/backport-539-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/asynchronous-search/backport-2.x
Then, create a pull request where the base
branch is 2.x
and the compare
/head
branch is backport/backport-539-to-2.x
.
Description
Downstream change coming from security plugin: https://github.com/opensearch-project/security/pull/4061
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.