search

opensearch-project / asynchronous-search

:arrow_forward: Run queries in the background and retrieve partial results along the way
https://opensearch.org/docs/latest/search-plugins/async/index/
Apache License 2.0
29 stars 49 forks source link

Standardize build/test github actions and java versions #623

Closed finnegancarroll closed 1 month ago

finnegancarroll commented 2 months ago

Description

Remove hard coded java versions - use java.matrix instead so we can easily add and remove java versions for each workflow. Build/publish/release with all supported versions - 11/17/21. Test only with java 21.

Standardize version of github actions: actions/setup-java to v4 actions/checkout to v4

For containerized workflows the image published by opensearch-build does not have a high enough version of glibc to support these v4 actions. Here we downgrade to v3 which only needs node 16 and set `ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true.

Related Issues

Should fix publish failure with java upgrade for that workflow: 11 -> 21.

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

mch2 commented 1 month ago

@finnegancarroll This largely looks right to me, but i am not sure why this PR did not run the test & build workflows? Is this related to your update?

finnegancarroll commented 1 month ago

Moved all workflows to java 21 only. Per https://github.com/opensearch-project/asynchronous-search/blob/main/build.gradle#L84 java 21 is the minimal compatible version on main.