search

opensearch-project / asynchronous-search

:arrow_forward: Run queries in the background and retrieve partial results along the way
https://opensearch.org/docs/latest/search-plugins/async/index/
Apache License 2.0
29 stars 49 forks source link

Enable custom start commands and options to resolve GHA issues #676

Closed peterzhuamazon closed 1 week ago

peterzhuamazon commented 2 weeks ago

Description

Enable custom start commands and options to resolve GHA issues

Related Issues

Closes #666 https://github.com/opensearch-project/asynchronous-search/pull/673 https://github.com/opensearch-project/opensearch-build/issues/5178

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peterzhuamazon commented 2 weeks ago

Hi @finnegancarroll @cwperks please take a look on this.

Thanks.

amitgalitz commented 2 weeks ago

Should we also update actions/setup-java to v4?

peterzhuamazon commented 2 weeks ago

Should we also update actions/setup-java to v4?

This particular PR is just to update previously failed and unsupported upload artifact actions. And yes you can definitely raise another PR for updating all actions if needed.

Thanks.

amitgalitz commented 2 weeks ago

Should we also update actions/setup-java to v4?

This particular PR is just to update previously failed and unsupported upload artifact actions. And yes you can definitely raise another PR for updating all actions if needed.

Thanks.

Sounds good, just mentioned cause I think I faced some node issue for the setup-java upgrades. Not a maintainer on this repo but updating on a different PR sounds good

opensearch-trigger-bot[bot] commented 1 week ago

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/asynchronous-search/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/asynchronous-search/backport-1.3
# Create a new branch
git switch --create backport/backport-676-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8caf59ca49a3fa8c80cf05b1877b29bf32afd8b2
# Push it to GitHub
git push --set-upstream origin backport/backport-676-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/asynchronous-search/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-676-to-1.3.

opensearch-trigger-bot[bot] commented 1 week ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/asynchronous-search/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/asynchronous-search/backport-2.x
# Create a new branch
git switch --create backport/backport-676-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8caf59ca49a3fa8c80cf05b1877b29bf32afd8b2
# Push it to GitHub
git push --set-upstream origin backport/backport-676-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/asynchronous-search/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-676-to-2.x.