Closed prudhvigodithi closed 2 months ago
I think all of this needs tests at a minimum. There's no way we're going to have an app where thousands of lines of code gets deployed across all repos without some assurance that they will actually work.
I agree with you @dblock, I'm waiting for Peter to define a test workflow in this repo, we should add tests and proper code coverage before we switch to public. Thanks @peterzhuamazon
I think all of this needs tests at a minimum. There's no way we're going to have an app where thousands of lines of code gets deployed across all repos without some assurance that they will actually work.
Yes DB, I totally agree we need test here. Once we get it public tomorrow we will start adding tests to it before adding more functions.
Thanks.
Added few tests for OpensearchClient
in test/utility/opensearchclient.test.ts
, @peterzhuamazon please let me know if we want to have testing done this way or any specific framework to be used for this automation app.
Thank you
Added few tests for
OpensearchClient
intest/utility/opensearchclient.test.ts
, @peterzhuamazon please let me know if we want to have testing done this way or any specific framework to be used for this automation app. Thank you
Thanks @prudhvigodithi we will be following instructions here: https://probot.github.io/docs/testing/
Some examples you can check here: https://github.com/wip/app/tree/master/test https://github.com/dcoapp/app/tree/main/test
I will do some research and make tweaks based on your changes as well. Thanks.
Thanks @peterzhuamazon will take a look at your comments, for now added .licenserc.json
.
@peterzhuamazon addressed your comments and updated the build.yml
to build-test.yml
to include some testing during the PR creation, please take a look.
Added two new tests github-merged-pulls-monitor.test.ts
and github-workflow-runs-monitor.test.ts
.
Description
Initial Version to Monitor Github workflows:
pull_request.closed
andworkflow_run.completed
events.github-merged-pulls-monitor
andgithub-workflow-runs-monitor
to parse the events and index to the metrics cluster.OpensearchClient
to useAwsSigv4Signer
and connect to the metrics cluster.OperationConfig
to support the newconfigSchema
forargs
..licenserc.json
.OpensearchClient
andgithub-merged-pulls-monitor
andgithub-workflow-runs-monitor
.build.yml
tobuild-test.yml
to include some testing during the PR creation.Issues Resolved
Part of https://github.com/opensearch-project/opensearch-build/issues/4941#issue-2463873587
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.