search

opensearch-project / cross-cluster-replication

Synchronize your data across multiple clusters for lower latencies and higher availability
https://opensearch.org/docs/latest/replication-plugin/index/
Apache License 2.0
48 stars 58 forks source link

Remove references to admin:admin #1298

Closed derek-ho closed 8 months ago

derek-ho commented 9 months ago

Description

Recently, security repo removed the hard coded admin:admin that comes from the demo configuration setup script. This makes the corresponding change. Integtest.sh is not used, and should be removed as per: https://github.com/opensearch-project/opensearch-build/issues/497

Issues Resolved

[List any issues this PR will resolve]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (be24bfa) 74.03% compared to head (2925971) 74.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1298 +/- ## ============================================ + Coverage 74.03% 74.57% +0.54% - Complexity 1022 1028 +6 ============================================ Files 141 141 Lines 4783 4783 Branches 526 526 ============================================ + Hits 3541 3567 +26 + Misses 889 869 -20 + Partials 353 347 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

monusingh-1 commented 9 months ago

@derek-ho the default integtest.sh present in opensearch-build will not run the complete integ test suite as it not handle multi-node multi-cluster topology for integtest runs.

monusingh-1 commented 9 months ago

from https://github.com/opensearch-project/opensearch-build/issues/497 However, if a plugin requires some custom logic to run integtests, which the standard tool doesn't provide, they can continue maintaining this integtest.sh in their own repo.

I think we should continue to maintain integtest.sh in this repo.

derek-ho commented 9 months ago

Ack. I will revert the deletion of the file. @monusingh-1 can you double check there seems to be a security CI failure not related to this change. This change has been backported to 2.x line, so we can try and resolve any CI failures in this PR related to the change. Thanks!

derek-ho commented 8 months ago

@monusingh-1 can you take another look? Is security tests a known issue/related to admin credential changes?