search

opensearch-project / custom-codecs

OpenSearch custom lucene codecs for providing different on-disk index encoding (e.g., compression).
Apache License 2.0
8 stars 15 forks source link

[BUG] QAT specific settings should only applicable for QAT codecs only. #170

Open sarthakaggarwal97 opened 3 months ago

sarthakaggarwal97 commented 3 months ago

What is the bug?

In the current implementation, the index.codec.qatmode is introduced but it does not validate if the setting can be applied to all codecs or not. Ideally, this setting should be applied only for QAT codecs.

How can one reproduce the bug?

Request:

curl --location --request PUT 'http://localhost:9200/index-10045' \
--header 'Content-Type: application/json' \
--data-raw '{
  "settings": {
    "index": {
      "codec": "zstd",
      "codec.qatmode": "auto"
    }
  }
}'

Response:

{
    "acknowledged": true,
    "shards_acknowledged": true,
    "index": "index-10045"
}

What is the expected behavior?

QAT specific settings should only be applied for QAT codecs

dblock commented 3 months ago

Catch All Triage - 1, 2, 3