search

opensearch-project / custom-codecs

OpenSearch custom lucene codecs for providing different on-disk index encoding (e.g., compression).
Apache License 2.0
6 stars 14 forks source link

Resolve dependency issues between jar and zip maven publications #39

Closed peterzhuamazon closed 10 months ago

peterzhuamazon commented 10 months ago

Description

Resolve dependency issues between jar and zip maven publications

Issues Resolved

https://github.com/opensearch-project/opensearch-build/issues/3743 Closes https://github.com/opensearch-project/custom-codecs/issues/38

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peterzhuamazon commented 10 months ago

Results:


% ls ~/.m2/repository/org/opensearch/opensearch-custom-codecs/2.10.0.0
opensearch-custom-codecs-2.10.0.0.jar  opensearch-custom-codecs-2.10.0.0-javadoc.jar  opensearch-custom-codecs-2.10.0.0.module  opensearch-custom-codecs-2.10.0.0.pom  opensearch-custom-codecs-2.10.0.0-sources.jar

% cat ~/.m2/repository/org/opensearch/opensearch-custom-codecs/2.10.0.0/opensearch-custom-codecs-2.10.0.0.pom | grep group
  <groupId>org.opensearch</groupId>
      <groupId>com.github.luben</groupId>
          <groupId>*</groupId>

% ls build/local-staging-repo/org/opensearch/opensearch-custom-codecs/2.10.0.0
opensearch-custom-codecs-2.10.0.0.jar         opensearch-custom-codecs-2.10.0.0-javadoc.jar         opensearch-custom-codecs-2.10.0.0.module         opensearch-custom-codecs-2.10.0.0.pom         opensearch-custom-codecs-2.10.0.0-sources.jar
opensearch-custom-codecs-2.10.0.0.jar.md5     opensearch-custom-codecs-2.10.0.0-javadoc.jar.md5     opensearch-custom-codecs-2.10.0.0.module.md5     opensearch-custom-codecs-2.10.0.0.pom.md5     opensearch-custom-codecs-2.10.0.0-sources.jar.md5
opensearch-custom-codecs-2.10.0.0.jar.sha1    opensearch-custom-codecs-2.10.0.0-javadoc.jar.sha1    opensearch-custom-codecs-2.10.0.0.module.sha1    opensearch-custom-codecs-2.10.0.0.pom.sha1    opensearch-custom-codecs-2.10.0.0-sources.jar.sha1
opensearch-custom-codecs-2.10.0.0.jar.sha256  opensearch-custom-codecs-2.10.0.0-javadoc.jar.sha256  opensearch-custom-codecs-2.10.0.0.module.sha256  opensearch-custom-codecs-2.10.0.0.pom.sha256  opensearch-custom-codecs-2.10.0.0-sources.jar.sha256
opensearch-custom-codecs-2.10.0.0.jar.sha512  opensearch-custom-codecs-2.10.0.0-javadoc.jar.sha512  opensearch-custom-codecs-2.10.0.0.module.sha512  opensearch-custom-codecs-2.10.0.0.pom.sha512  opensearch-custom-codecs-2.10.0.0-sources.jar.sha512

% cat build/local-staging-repo/org/opensearch/opensearch-custom-codecs/2.10.0.0/opensearch-custom-codecs-2.10.0.0.pom | grep group
  <groupId>org.opensearch</groupId>
      <groupId>com.github.luben</groupId>
          <groupId>*</groupId>

% ls build/local-staging-repo/org/opensearch/plugin/opensearch-custom-codecs/2.10.0.0/
opensearch-custom-codecs-2.10.0.0.pom      opensearch-custom-codecs-2.10.0.0.pom.sha1    opensearch-custom-codecs-2.10.0.0.pom.sha512  opensearch-custom-codecs-2.10.0.0.zip.md5   opensearch-custom-codecs-2.10.0.0.zip.sha256
opensearch-custom-codecs-2.10.0.0.pom.md5  opensearch-custom-codecs-2.10.0.0.pom.sha256  opensearch-custom-codecs-2.10.0.0.zip         opensearch-custom-codecs-2.10.0.0.zip.sha1  opensearch-custom-codecs-2.10.0.0.zip.sha512

% cat build/local-staging-repo/org/opensearch/plugin/opensearch-custom-codecs/2.10.0.0/opensearch-custom-codecs-2.10.0.0.pom | grep group
  <groupId>org.opensearch.plugin</groupId>
peterzhuamazon commented 10 months ago

Is line 49 correct?

group 'org.opensearch'

Yes, that is by design so group vs groupid is different here.