search

opensearch-project / custom-codecs

OpenSearch custom lucene codecs for providing different on-disk index encoding (e.g., compression).
Apache License 2.0
6 stars 13 forks source link

[BUG] Upgrade custom implementation to use Lucene99Codec #94

Closed mgodwan closed 5 months ago

mgodwan commented 5 months ago

OS 2.x branch recently upgraded to use Lucene 9.9.1

We need to evaluate if we require changes in custom-codecs as well to rely on the new codecs introduced.

e.g. https://github.com/opensearch-project/custom-codecs/blob/main/src/main/java/org/opensearch/index/codec/customcodecs/Lucene95CustomCodec.java#L93C36-L93C49

mgodwan commented 5 months ago

If we don't have upgrade tests, I think we also should add the same as part of this exercise. @sarthakaggarwal97 Can you please check?

sarthakaggarwal97 commented 5 months ago

Thanks @mgodwan for creating the issue. Will take a look.

andrross commented 5 months ago

99 has been merged to 2.x. Next we need to forward-port that change to main.

sarthakaggarwal97 commented 5 months ago

Closing this as the change is merged! thanks