opensearch-project / dashboards-assistant

Dashboard assistant is a way for users on OpenSearch Dashboards to interact with an assistant through chat or the different OSD pages
https://opensearch.org/
Apache License 2.0
17 stars 22 forks source link

switch to ml_configuration in agent response as backend changed #239

Closed qianheng-aws closed 1 month ago

qianheng-aws commented 1 month ago

Description

The backend ml-commons changed its configuration field from configuration to ml_configuration and lead to error.

GET /_plugins/_ml/config/os_chat

{
  "config_type": "os_chat_root_agent",
  "ml_configuration": {
    "agent_id": "******************"
  }
}

Related change in ml-commons: https://github.com/opensearch-project/ml-commons/pull/2710

Issues Resolved

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

wanglam commented 1 month ago

Is this change target for 2.16?

qianheng-aws commented 1 month ago

Is this change target for 2.16?

The ml-commons related change https://github.com/opensearch-project/dashboards-assistant/pull/239#issuecomment-2247335910 has backported to 2.16, so I think this change should target for 2.16 as well

raintygao commented 1 month ago

It would be better to add your change in https://github.com/opensearch-project/dashboards-assistant/blob/main/release-notes/dashboards-assistant.release-notes-2.16.0.0.md as this should be released in 2.16.

qianheng-aws commented 1 month ago

It would be better to add your change in https://github.com/opensearch-project/dashboards-assistant/blob/main/release-notes/dashboards-assistant.release-notes-2.16.0.0.md as this should be released in 2.16.

@raintygao But it cannot be called a feature nor bug fix. Maybe Maintenance?

raintygao commented 1 month ago

It would be better to add your change in https://github.com/opensearch-project/dashboards-assistant/blob/main/release-notes/dashboards-assistant.release-notes-2.16.0.0.md as this should be released in 2.16.

@raintygao But it cannot be called a feature nor bug fix. Maybe Maintenance?

Im okay to this.