Closed AMoo-Miki closed 3 weeks ago
Thanks @AMoo-Miki, any background of these changes?(guess it's about look & feel) Are these changes for 2.17?
Yes. They are all look and feel related. Also, please merge this as soon as you can. Not only is it for 2.17 but also, I won't be able to support the PRs much longer.
From the code changes, mostly are look & feel change but could you please post with a screenshot before and after so that we can easily tell if it is good enough for us to merge.
The backport to 2.x
failed:
The process '/usr/bin/git' failed with exit code 128
To backport manually, run these commands in your terminal:
# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-assistant/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-assistant/backport-2.x
# Create a new branch
git switch --create backport/backport-250-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f8ed66c50c747aaeb6e48149ad29c8b1ccee027
# Push it to GitHub
git push --set-upstream origin backport/backport-250-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-assistant/backport-2.x
Then, create a pull request where the base
branch is 2.x
and the compare
/head
branch is backport/backport-250-to-2.x
.
Replace instances of
EuiButton
that don't have an explicit sizing attribute toEuiSmallButton*
. Replace instances ofEui<form elements>
that don't have density attributes toEuiCompressed<form elements>
.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.