Removes all instances of pulling in public/ modules into common. This breaks things when trying to run the built plugin (compiled JS) in a distribution build, but doesn't cause errors in a dev environment otherwise. The consequence of moving these, is a bunch of import refactoring was needed across all files. Audited all moved imports to ensure none are missed, also sanity tested plugin flows. Also adds a one-line change to handle an edge-case NPE.
Check List
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Description
Removes all instances of pulling in
public/modules intocommon. This breaks things when trying to run the built plugin (compiled JS) in a distribution build, but doesn't cause errors in a dev environment otherwise. The consequence of moving these, is a bunch of import refactoring was needed across all files. Audited all moved imports to ensure none are missed, also sanity tested plugin flows. Also adds a one-line change to handle an edge-case NPE.Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.