Closed saimedhi closed 3 weeks ago
Could you mark the PR as a draft until you have completed the end-to-end testing? It includes:
# Set the value of this setting to true to enable multiple data source feature.
#data_source.enabled: false
# Set the value of this setting to true to hide local cluster in data source feature.
#data_source.hideLocalCluster: false
Thanks for the change! Two things I noticed from the screen recording:
dataSourceId=
in the url on new_workflow
page when local cluster is selected. Let's add that to keep all pages url in consistent when the feature flag is enabledWorkflows
page and to see if they all work as expected? @saimedhi looking great! Once my remaining comments on public/route_service.ts
are addressed and you can confirm all of the functionality is still working as expected, I am happy to approve :)
Changes LGTM! One more request to add details in the PR description, including some of the low-level implementation details. See existing merged PRs as an example. This makes it much easier to track down issues that may come up in the future, and keeps a detailed log of what and when changes were made, and the motivation behind them.
Remote data source should be consistent in breadcrumbs. When go back to workflow page,
local cluster
should be selected instead of selecting the default data source. Could you address this bug?
@jackiehanyang, I will fix it in a followup PR. Thank you.
Remote data source should be consistent in breadcrumbs. When go back to workflow page,
local cluster
should be selected instead of selecting the default data source. Could you address this bug?@jackiehanyang, I will fix it in a followup PR. Thank you.
- I will make sure when we go back to workflow page, data source selected will be retained .
I see a bug - when you opening flow framework from the side nav, default remote data source should be selected and the dataSourceId should exist in the url
Please thoroughly test the following scenarios:
Description
Issues Resolved
closes #228
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.