[BUG]Missing dataSourceId in URL When clicking Flow Framework from side nav

opensearch-project / dashboards-flow-framework

A UI designer for constructing AI applications with OpenSearch

Apache License 2.0

9 stars 8 forks source link

[BUG]Missing dataSourceId in URL When clicking Flow Framework from side nav #275

Open saimedhi opened 3 months ago

saimedhi commented 3 months ago

What is the bug? As stated in MDS feature addition PR here, when clicking Flow Framework from side nav, dataSourceId is not retained in url. So, when page is refreshed as seen below, default datasource page is opened instead of current selected datasource.

Bug can be reproduced as below: screen-capture (4).webm

What is the expected behavior?

When clicking Flow Framework from side nav, url should retain datasourceId.

saimedhi commented 3 months ago

Issue also exists in https://github.com/opensearch-project/anomaly-detection-dashboards-plugin.
I'll check if this issue can be resolved within the plugin.

ohltyler commented 3 months ago

@saimedhi is this issue resolved?

saimedhi commented 3 months ago

@saimedhi is this issue resolved?

No, I think this is a known issue in side nav implementation. Will connect with Zhou Su and confirm the same.

ohltyler commented 2 months ago

@saimedhi is this still a known issue?

saimedhi commented 2 months ago

Yes Tyler, OSD Relavant issue is here. I will try to fix this issue.
From discussion with Zhou Su, as flow framework do not have sub features in new left navigation. Fixing this issue is like an enhancement. Where plugins like AD, Fixing this issue is mandatory. Will work on this issue soon.