opensearch-project / dashboards-maps

:globe_with_meridians: User interface for the backend geospatial plugin which can be integrated with OpenSearch Dashboards and a home for all other map related features.
https://opensearch.org/docs/latest/dashboards/geojson-regionmaps/#custom-vector-maps-with-geojson
Apache License 2.0
17 stars 44 forks source link

[FEATURE Enhancement] Icon Fixed/by Value in document layer #568

Open canascar opened 8 months ago

canascar commented 8 months ago

Is your feature request related to a problem?

As dashboards-maps user, i should be able to style my geospatial field values as different icons based on contents of my field. RELATED: https://github.com/opensearch-project/dashboards-maps/issues/472

Playground https://playground.opensearch.org/app/maps-dashboards/88a24e6c-0216-4f76-8bc7-c8db6c8705da

What solution would you like?

Add support to use data driven styling in displaying geospatial field as icons in document layer.

Do you have any additional context?

Marker (Default currently available) Marker - Current All the same with the addition of a button group to toggle between Marker/Icon UI inputs


Fixed Icon Icon fixed User will be able to select from available default map icons or upload their own.

Available map icons as individual or sets These will be part of the OUI icon pack but used specifically for map visualizations icons

Icon by value

-Selecting icon set The dropdown displays existing map icons as sets (Filled/Outline) or customer can choose to custom select icons and areas of representation by defined parameters.

The layer list displays the breakdown of the field value/range represented by the icon

Icon by value-1

Custom icon Available for fixed and by value icon selection User will be able to upload their own SVG to add to the dropdown for better representation of their data points. Add custom icon

kamingleung commented 8 months ago

@canascar For Icon by value, does this let users display the text values on the map instead of icons? If so, does it make sense to have Text/Value as a 3rd option under Symbol type?

  1. I wonder if the terms Fixed and By Value are clear to users on what functionality they offer.
  2. Is there a need for users to remove custom icons they have uploaded?
canascar commented 8 months ago

Hi @kamingleung

  1. we are using these terms in Cluster layers as well to denote whether the user is selecting data points populated fixed by the entire data set of by value of a selected field within the data.
  2. When the user uploads the icons they will be stored and will be reusable in other map visualizations, listed in the dropdown under Custom icons.
kamingleung commented 8 months ago
  1. Perhaps providing some context upfront to users may be helpful? Either with helper text or help icon popover.
  2. I wonder if there's a way to delete custom icons the users have uploaded?
canascar commented 8 months ago

@kamingleung

  1. Sure, I can work on adding something in.
  2. Icons would populate the dropdown in their own category "Custom icons" and it's the only area where they would be accessible. We can however, discuss if it's necessary for the option to delete (as they will always be able to choose whether or not to use the file) but it would be another flow to consider that may push the release of this enhancement. Perhaps it's a P1 or P2 addition. I can talk to devs about it.
kamingleung commented 7 months ago

@canascar

  1. Were you able to make changes to provide users some upfront context?
  2. I don’t think it’s a release blocker if users cannot delete custom icons, but it should be a fast follow.
canascar commented 7 months ago

@kamingleung Ah yes.. help info - rethinking this one - do you suggest adding to all fields? I am wondering where perhaps you may envision this- also the questionInCircle - is that a pattern we are adopting more regularly in our field labels?

kamingleung commented 7 months ago

I would suggest only adding help info on the fields that may benefit with additional context. We can leverage the hover questionInCircle pattern – especially on a compressed space like this.

canascar commented 7 months ago

I would suggest only adding help info on the fields that may benefit with additional context. We can leverage the hover questionInCircle pattern – especially on a compressed space like this.

Added help content to enhance in-context documentation @kamingleung please review, thanks!

Screenshot 2024-02-08 at 9 43 40 AM
kamingleung commented 7 months ago

@canascar Thanks for the updates. Looks good to me!

dblock commented 2 months ago

Was this completed? Can this be closed?

Catch All Triage - 1 2 3 4 5