search

opensearch-project / dashboards-maps

:globe_with_meridians: User interface for the backend geospatial plugin which can be integrated with OpenSearch Dashboards and a home for all other map related features.
https://opensearch.org/docs/latest/dashboards/geojson-regionmaps/#custom-vector-maps-with-geojson
Apache License 2.0
17 stars 44 forks source link

fix build failed due to missing babel plugins #570

Closed ruanyl closed 7 months ago

ruanyl commented 8 months ago

Description

Resolved: https://github.com/opensearch-project/dashboards-maps/issues/566 https://github.com/opensearch-project/dashboards-maps/issues/569

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ruanyl commented 8 months ago

This should backport to 2.x

ruanyl commented 8 months ago

@VijayanB @junqiu-lei could you take a look at this PR?

ryanbogan commented 8 months ago

There is another file that needs to be changed as well for the build to run successfully. I'll be raising a PR that contains the babel change and fixes other tests that are failing too.

ruanyl commented 8 months ago

There is another file that needs to be changed as well for the build to run successfully. I'll be raising a PR that contains the babel change and fixes other tests that are failing too.

If they are unrelated, let's put them in different PRs, please merge this PR and you could raise another PR for the test fixes.

ryanbogan commented 7 months ago

Code change included in https://github.com/opensearch-project/dashboards-maps/pull/572

ruanyl commented 7 months ago

Thanks for fixing this, however, I personally think it's generally not a good practice to squash unrelated changes into one commit.