search

opensearch-project / dashboards-maps

:globe_with_meridians: User interface for the backend geospatial plugin which can be integrated with OpenSearch Dashboards and a home for all other map related features.
https://opensearch.org/docs/latest/dashboards/geojson-regionmaps/#custom-vector-maps-with-geojson
Apache License 2.0
17 stars 44 forks source link

[FEATURE] Support Multiple Data Source in Maps Dashboards Plugin #584

Closed BionIT closed 6 months ago

BionIT commented 7 months ago

Is your feature request related to a problem?

With multiple data source enabled, users of OpenSearch Dashboards are able to create data source connections and query local and remote OpenSearch clusters. Enabling multiple data source at dashboards plugin would ensure users that have been using the multiple data source feature to have a consistent experience in the dashboard, and allows users to use the same dashboard for different clusters.

What solution would you like?

Support multiple data source in the maps dashboards plugin

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?

Add any other context or screenshots about the feature request here.

BionIT commented 6 months ago

Thanks @kgcreative @junqiu-lei for the sync up! A quick summary from the offline meeting: Maps plugin uses index pattern which already supports multiple data source. During the walk through, we did find a few things we need to address before close out:

  1. Change the label from Data source to Index pattern at the location below - @junqiu-lei Screenshot 2024-02-19 at 3 37 51 PM
  2. Fix the combo box which shows 2 options selected - @junqiu-lei @BionIT
  3. Add data source connection name as prefix to the selector - @BionIT will look into this and evaluate if we can use the component in discover page
junqiu-lei commented 6 months ago

Thanks @BionIT for the clear summary!

BionIT commented 6 months ago

For 3, I have created an issue in dashboards repo https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5900

BionIT commented 6 months ago

Thanks @junqiu-lei for merging the label change! Now we have 1-3 closed. @kgcreative should we do a quick demo for the maps plugin before closing this out?

kgcreative commented 6 months ago

@junqiu-lei can you either post before/after screenshots, or a screen recording here? I think we can review and close out async

junqiu-lei commented 6 months ago

@kgcreative @BionIT Hi, I made a screen recording for the maps multi data source support, please review, thanks!

https://github.com/opensearch-project/dashboards-maps/assets/90288540/4dcf37f8-2c08-4fe5-8efb-c587a7b7c464

kgcreative commented 6 months ago

LGTM! Ship it!