search

opensearch-project / dashboards-maps

:globe_with_meridians: User interface for the backend geospatial plugin which can be integrated with OpenSearch Dashboards and a home for all other map related features.
https://opensearch.org/docs/latest/dashboards/geojson-regionmaps/#custom-vector-maps-with-geojson
Apache License 2.0
17 stars 46 forks source link

Use new header to maps listing page #653

Closed junqiu-lei closed 2 months ago

junqiu-lei commented 3 months ago

Description

This PR adds the changes to apply new header to maps listing page when turn on home:useNewHomePage in advanced setting.

The code change in maps-dashboards plugin mainly is moving Create map button from table to header by using HeaderControl provided from OSD header collective branch navigation component.

This PR is target to feature/new-header branch, since above OSD code change isn't available in main branch yet. Will add integ test after this PR and OSD feature code is merged to main.

Screenshot

When turn off home:useNewHomePage(by default)

Screenshot 2024-08-09 at 12 56 41 PM

When turn on home:useNewHomePage

Screenshot 2024-08-09 at 12 56 13 PM

Issues Resolved

Part of https://github.com/opensearch-project/dashboards-maps/issues/649

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

AMoo-Miki commented 2 months ago

The header changes look good.

Just in case it is not on your radar, the page body also needs updating to use whole width of the page.

junqiu-lei commented 2 months ago

The header changes look good.

Just in case it is not on your radar, the page body also needs updating to use whole width of the page.

Just offline synced up with @AMoo-Miki, there is hardcoded width restriction in TableListView component from OSD, Miki will help to make the table width changeable. Then I can raise another PR for the maps listing page width change align with UX mock.