Closed riysaxen-amzn closed 6 months ago
Noticed that in the test, local cluster is the default being selected, but it should be default data source being selected, my assumption it's due to the data source id is set to empty string which is not right. Let's not give data source id a default value before page load and instead, we should get the data source id from the call back function passed to the data source component
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.03%. Comparing base (
1fc2abe
) to head (1335553
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The backport to 2.x
failed:
The process '/usr/bin/git' failed with exit code 128
To backport manually, run these commands in your terminal:
# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-186-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 59a1545c58e734e19c039e7a00830b43f2742920
# Push it to GitHub
git push --set-upstream origin backport/backport-186-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x
Then, create a pull request where the base
branch is 2.x
and the compare
/head
branch is backport/backport-186-to-2.x
.
Description
This PR adds MDS support to Notifications Plugin
Issues Resolved
Issue #159
Testing
Channels
https://github.com/opensearch-project/dashboards-notifications/assets/69919272/3a0b421d-05ed-47f9-a1fe-39eb84a8f104
EmailSenders
https://github.com/opensearch-project/dashboards-notifications/assets/69919272/37a9e600-be55-440e-bf2a-38a9d905a1ed
EmailRecepientGroups
https://github.com/opensearch-project/dashboards-notifications/assets/69919272/63e00194-703f-4342-8bd4-216cc5b7a5c2
SendTestMessage
https://github.com/opensearch-project/dashboards-notifications/assets/69919272/5f8e0c2e-2a60-4565-a1cc-ee63cd9f7200
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.