search

opensearch-project / dashboards-notifications

The Notifications plugin provides a central location for all of your notifications from OpenSearch plugins. You can use either OpenSearch Dashboards or the REST API to configure notifications. Dashboards offers a more organized way of selecting a channel type and selecting which OpenSearch plugin sources you want to use.
Apache License 2.0
9 stars 37 forks source link

Fix broken osd functional test repo #189

Closed riysaxen-amzn closed 6 months ago

riysaxen-amzn commented 6 months ago

Description

This PR will fix the broken osd repo functional tests

Issues Resolved

Testing

https://github.com/opensearch-project/dashboards-notifications/assets/69919272/9538ea20-f5d4-4b56-ba58-c0db486ad4b7

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

yujin-emma commented 6 months ago

Could you please add a video in the description to show the notification is healthy with the fix

BionIT commented 6 months ago

Can we fix the reference in server folder, eg. https://github.com/opensearch-project/dashboards-notifications/pull/188/files#diff-6495f662f11eb9366b891c845ddac043c64b34f3a11695a2bdb0d55f58169d4cR14

riysaxen-amzn commented 6 months ago

Overall look good to me, since the CHANNEL_TYPE and BACKEND_CHANNEL_TYPE are the only constant that used in server folder but defined in public folder previously, this fix will be fine for now. But for long term, I prefer to moving all the shared utils under common folder.

i agree

SuZhou-Joe commented 6 months ago

Should close #185

BionIT commented 6 months ago

Could we backport this fix to 2.x? @AWSHurneyt @SuZhou-Joe

opensearch-trigger-bot[bot] commented 6 months ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-189-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e59708146ddb77b350a9b79a465af3bd5725892b
# Push it to GitHub
git push --set-upstream origin backport/backport-189-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-189-to-2.x.

SuZhou-Joe commented 6 months ago

@BionIT this PR should be backported after #181. And @amsiglan @riysaxen-amzn could you please help to backport as you have more context than us and you are the authors of the PRs related. and we are afraid we may make an unnecessary backport by accident.