search

opensearch-project / dashboards-notifications

The Notifications plugin provides a central location for all of your notifications from OpenSearch plugins. You can use either OpenSearch Dashboards or the REST API to configure notifications. Dashboards offers a more organized way of selecting a channel type and selecting which OpenSearch plugin sources you want to use.
Apache License 2.0
9 stars 35 forks source link

side navigation changes for notifications #222

Closed riysaxen-amzn closed 1 month ago

riysaxen-amzn commented 1 month ago

Description

Issues Resolved

After side nav changes, when feature is enabled

Image 7-18-24 at 5 39 PM (1) Image 7-18-24 at 5 39 PM

When feature is disabled:

Image 7-18-24 at 7 22 AM

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.83%. Comparing base (1fc2abe) to head (3da9b1c). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ========================================== - Coverage 86.70% 84.83% -1.87% ========================================== Files 52 54 +2 Lines 1497 1583 +86 Branches 373 414 +41 ========================================== + Hits 1298 1343 +45 - Misses 196 237 +41 Partials 3 3 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/dashboards-notifications/pull/222/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [dashboards-notifications](https://app.codecov.io/gh/opensearch-project/dashboards-notifications/pull/222/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `84.83% <ø> (-1.87%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.