search

opensearch-project / dashboards-notifications

The Notifications plugin provides a central location for all of your notifications from OpenSearch plugins. You can use either OpenSearch Dashboards or the REST API to configure notifications. Dashboards offers a more organized way of selecting a channel type and selecting which OpenSearch plugin sources you want to use.
Apache License 2.0
10 stars 37 forks source link

add riysaxen as maintainer #240

Closed riysaxen-amzn closed 2 months ago

riysaxen-amzn commented 2 months ago

Description

Issues Resolved

[List any issues this PR will resolve]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

riysaxen-amzn commented 2 months ago

UTs passing locally:


 PASS  public/pages/Channels/__tests__/ChannelSettingsDetails.test.tsx (22.27 s)
 PASS  public/pages/Emails/__tests__/SendersTable.test.tsx (28.032 s)
 PASS  public/pages/Main/__tests__/Main.test.tsx (24.408 s)
 PASS  server/utils/__tests__/helper.test.ts (6.659 s)
 PASS  public/pages/CreateChannel/__tests__/CreateRecipientGroupModal.test.tsx (26.883 s)
 PASS  public/utils/__tests__/helper.test.ts
 PASS  public/components/__tests__/ContentPanel.test.tsx (18.595 s)
 PASS  public/components/__tests__/ContentPanelActions.test.tsx (18.564 s)
 PASS  public/pages/Emails/__tests__/EmailGroups.test.tsx (19.163 s)
 PASS  public/pages/Channels/__tests__/DetailsTableModal.test.tsx (20.653 s)
 PASS  public/pages/Channels/__tests__/DetailsListModal.test.tsx (13.826 s)
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.

Test Suites: 45 passed, 45 total
Tests:       3 skipped, 146 passed, 149 total
Snapshots:   83 passed, 83 total
Time:        361.117 s
Ran all test suites.
opensearch-trigger-bot[bot] commented 2 months ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-240-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0bad4889c457176bc57a93b2fa8c953d4ef1693f
# Push it to GitHub
git push --set-upstream origin backport/backport-240-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-240-to-2.x.