opensearch-project / dashboards-observability

Visualize and explore your logs, traces and metrics data in OpenSearch Dashboards
https://opensearch.org/docs/latest/observability-plugin/index/
Apache License 2.0
14 stars 46 forks source link

Trace Analytics v2 update - adding in conext views, updating filter, adding services metrics #1883

Closed ps48 closed 3 weeks ago

ps48 commented 3 weeks ago

Description

Below are the UX changes done for trace analytics v2, the PR is mainly restricted to changes in public/components/trace_analytics/ with minor state pass update in explorer. Tried to fix a lot of lint issues, still some of them are pending. Will create another PR for updating cypress and adding more jest tests for new components. Below is the list of features added in this PR:

Major files changes that need to be reviewed are the ones below, the other files are changes for theming, minor additions and test/lint updates

public/components/event_analytics/explorer/explorer.tsx
public/components/trace_analytics/components/common/filters/filter_helpers.tsx
public/components/trace_analytics/components/common/filters/filters.tsx
public/components/trace_analytics/components/common/helper_functions.tsx
public/components/trace_analytics/components/common/plots/service_map.tsx
public/components/trace_analytics/components/common/search_bar.tsx
public/components/trace_analytics/components/services/service_flyout.tsx
public/components/trace_analytics/components/services/service_metrics.tsx
public/components/trace_analytics/components/services/service_view.tsx
public/components/trace_analytics/components/services/services_content.tsx
public/components/trace_analytics/requests/services_request_handler.ts
public/components/trace_analytics/requests/queries/services_queries.ts
public/components/trace_analytics/components/traces/span_detail_flyout.tsx

Screenshot 2024-06-07 at 9 58 15 AM

Screenshot 2024-06-07 at 9 53 30 AM

Screenshot 2024-06-07 at 9 54 02 AM

Screenshot 2024-06-07 at 9 54 22 AM

Screenshot 2024-06-07 at 9 54 39 AM

Screenshot 2024-06-07 at 9 54 58 AM

Screenshot 2024-06-07 at 9 55 21 AM

Screenshot 2024-06-07 at 9 55 35 AM

Screenshot 2024-06-07 at 9 56 11 AM

Screenshot 2024-06-07 at 10 08 32 AM

Screenshot 2024-06-07 at 10 08 50 AM

Issues Resolved

[List any issues this PR will resolve]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-trigger-bot[bot] commented 3 weeks ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1883-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2a446bb990a92c071012668eacc581c629a88fe7
# Push it to GitHub
git push --set-upstream origin backport/backport-1883-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1883-to-2.x.