opensearch-project / dashboards-observability

Visualize and explore your logs, traces and metrics data in OpenSearch Dashboards
https://opensearch.org/docs/latest/observability-plugin/index/
Apache License 2.0
14 stars 46 forks source link

(query assist) revert removing backticks #1896

Closed joshuali925 closed 3 weeks ago

joshuali925 commented 3 weeks ago

Description

The two issues #509, #557 mentioned are still there, but PPL requires certain fields (i.e. fields with @) to be surrounded by backticks, otherwise there will be a syntax error. This PR reverts the behavior to allow those queries.

Issues Resolved

[List any issues this PR will resolve]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-trigger-bot[bot] commented 3 weeks ago

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.15
# Create a new branch
git switch --create backport/backport-1896-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b99920d5e2467f71387ee11b5e4de174f1761e72
# Push it to GitHub
git push --set-upstream origin backport/backport-1896-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport/backport-1896-to-2.15.