search

opensearch-project / dashboards-observability

Visualize and explore your logs, traces and metrics data in OpenSearch Dashboards
https://opensearch.org/docs/latest/observability-plugin/index/
Apache License 2.0
14 stars 52 forks source link

[Navigation] Register all plugins to NavGroups #1926

Closed TackAdam closed 2 months ago

TackAdam commented 3 months ago

Description

Demo.mov.zip

Screenshot 2024-07-18 at 4 46 03 PM Screenshot 2024-07-18 at 4 46 13 PM

This change adds a function that registers all the plugins to their corresponding NavGroups and NavCategories: <html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns="http://www.w3.org/TR/REC-html40">

Plug-in | Group | Category -- | -- | -- Notebooks | Observability | Dashboards and report Notebooks | Security Analytics | Dashboards and report Notebooks | Analytics | Dashboards and report Integrations | Observability | Dashboards and report Integrations | Security Analytics | Dashboards and report Integrations | Analytics | Dashboards and report Metrics | Observability | Investigate Applications | Observability | Dashboards and report Traces | Observability | Investigate

Issues Resolved

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/7029

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

joshuali925 commented 3 months ago

~should this be done inside each plugin? rather than in observability~ nvm i just realized Discover is log explore, not OSD Discover

TackAdam commented 2 months ago

Latest commit reflects most recent mocks as of 7/17 While the new navigation is enabled logs, applications, and dashboards are disabled. Traces is broken into its sections of Traces and Services when it is enabled.

Screenshot 2024-07-17 at 2 36 33 PM
opensearch-trigger-bot[bot] commented 2 months ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1926-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09090a6d5ec0dc968de7493e6c8371b2dbbaa9cf
# Push it to GitHub
git push --set-upstream origin backport/backport-1926-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1926-to-2.x.