Fix Observability CI workflow checks

ps48 commented 3 months ago

Description

Add job scheduler to dashboards-observability CI, SQL plugin recently added this as an dependency leading the observability CI failing waiting for Job scheduler plugin. Related upstream PR: https://github.com/opensearch-project/sql/pull/2834
Removed datasources tests from observability plugin
Update link checker to exclude localhost links
Fixed link for getting strated

Issues Resolved

https://github.com/opensearch-project/dashboards-observability/issues/1886

Check List

[ ] New functionality includes testing.
- [ ] All tests pass, including unit test, integration test and doctest
[ ] New functionality has been documented.
- [ ] New functionality has javadoc added
- [ ] New functionality has user manual doc added
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

RyanL1997 commented 3 months ago

Should we also backport this?

derek-ho commented 3 months ago

Seems like CI still failing on install: https://github.com/opensearch-project/dashboards-observability/actions/runs/10292034044/job/28485578654?pr=2046

ps48 commented 3 months ago

@derek-ho The workflows are still using the old workflow file. I think the workflows will only get updated once merged in.

derek-ho commented 3 months ago

@ps48 it looks like its a different workflow file, I think you need to make the same change in this file: https://github.com/opensearch-project/dashboards-observability/blob/main/.github/workflows/integration-tests-workflow.yml#L56 here

ps48 commented 3 months ago

Thanks! @derek-ho that was a good catch, updated the PR

opensearch-trigger-bot[bot] commented 3 months ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-2046-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 61e6012bb7aed2611485dbdc460c57e39d68249c
# Push it to GitHub
git push --set-upstream origin backport/backport-2046-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2046-to-2.x.

opensearch-project / dashboards-observability