Closed RyanL1997 closed 1 month ago
Everything looks good with the feature flag enabled, but have some concerns when it is disabled.
When disabling it do we want to keep the original formatting? It currently places the new save action between the span and super date picker.
Attention: Patch coverage is 78.12500%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 54.75%. Comparing base (
c3ab50f
) to head (bee60d7
). Report is 54 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Only remaining difference I see from the mocks is the refresh for the super data picker. I don't see an option to change this within the picker though might need to be raised as a separate issue.
Looks correct with new navigation disabled now:
The backport to 2.x
failed:
The process '/usr/bin/git' failed with exit code 128
To backport manually, run these commands in your terminal:
# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-2050-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 65453a34fe87422070578d5e44dc982dbc34fd43
# Push it to GitHub
git push --set-upstream origin backport/backport-2050-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x
Then, create a pull request where the base
branch is 2.x
and the compare
/head
branch is backport/backport-2050-to-2.x
.
Description
New page header for metrics
Screenshots
Old Header page layout changes
New Header changes
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.