opensearch-project / dashboards-observability

Visualize and explore your logs, traces and metrics data in OpenSearch Dashboards
https://opensearch.org/docs/latest/observability-plugin/index/
Apache License 2.0
14 stars 52 forks source link

[Page Header] New page header for metrics #2050

Closed RyanL1997 closed 1 month ago

RyanL1997 commented 1 month ago

Description

New page header for metrics

Screenshots

Old Header page layout changes

Screenshot 2024-08-14 at 2 43 28 PM Screenshot 2024-08-14 at 2 43 37 PM

New Header changes

Screenshot 2024-08-14 at 2 44 17 PM

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

TackAdam commented 1 month ago

Everything looks good with the feature flag enabled, but have some concerns when it is disabled.

When disabling it do we want to keep the original formatting? It currently places the new save action between the span and super date picker.

Metrics_FeatureFlagDisabled
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.75%. Comparing base (c3ab50f) to head (bee60d7). Report is 54 commits behind head on main.

Files Patch % Lines
...mponents/metrics/top_menu/metrics_export_panel.tsx 55.55% 4 Missing :warning:
...lic/components/metrics/top_menu/metrics_export.tsx 94.11% 1 Missing :warning:
public/components/metrics/top_menu/top_menu.tsx 0.00% 1 Missing :warning:
public/plugin.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2050 +/- ## ========================================== - Coverage 57.85% 54.75% -3.10% ========================================== Files 372 394 +22 Lines 14081 15244 +1163 Branches 3712 4124 +412 ========================================== + Hits 8146 8347 +201 - Misses 5871 6816 +945 - Partials 64 81 +17 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/dashboards-observability/pull/2050/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [dashboards-observability](https://app.codecov.io/gh/opensearch-project/dashboards-observability/pull/2050/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `54.75% <78.12%> (-3.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TackAdam commented 1 month ago

Only remaining difference I see from the mocks is the refresh for the super data picker. I don't see an option to change this within the picker though might need to be raised as a separate issue.

Refresh_SuperDatePicker

Looks correct with new navigation disabled now:

Screenshot 2024-08-14 at 3 31 10 PM
opensearch-trigger-bot[bot] commented 1 month ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-2050-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 65453a34fe87422070578d5e44dc982dbc34fd43
# Push it to GitHub
git push --set-upstream origin backport/backport-2050-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2050-to-2.x.