opensearch-project / dashboards-observability

Visualize and explore your logs, traces and metrics data in OpenSearch Dashboards
https://opensearch.org/docs/latest/observability-plugin/index/
Apache License 2.0
14 stars 52 forks source link

Use smaller and compressed varients of buttons and form components #2068

Closed AMoo-Miki closed 1 month ago

AMoo-Miki commented 1 month ago

Description

Replace instances of EuiButton that don't have an explicit sizing attribute to EuiSmallButton*. Replace instances of Eui<form elements> that don't have density attributes to EuiCompressed<form elements>.

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

derek-ho commented 1 month ago

@ps48 @mengweieric can one of you folks review this and help get it merged?

ps48 commented 1 month ago

@AMoo-Miki Can you please update the 4 snapshots that are failing.

TackAdam commented 1 month ago

Can we wait on merging this until https://github.com/opensearch-project/dashboards-observability/pull/2063 gets approved/merged?

opensearch-trigger-bot[bot] commented 1 month ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-2068-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 69d12cee1b0e43869d078e30cc996e9d685e44a9
# Push it to GitHub
git push --set-upstream origin backport/backport-2068-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2068-to-2.x.